chore(icons): add a help icon svg partial - #7470
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7470.surge.sh A11y report: https://patternfly-pr-7470-a11y.surge.sh |
Collaborator
|
Hey hey. It looks like the forms are using Outlined Question Circle instead of help. I realize now my screenshot was misleading as it looks more like the outlined version. My apologies! |
mcoker
reviewed
Apr 22, 2025
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
LGTM though if it's no sweat, it would be good to remove the path from the icon-help partial name.
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7265
What
Adds a new help icon partial in the assets/images directory and updates several components to use it instead of Font Awesome's question-circle icon.
Changes
icon-help.hbstosrc/patternfly/assets/images/containing an SVG help iconHow
The icon is implemented as a handlebars partial that can be referenced using
button--icon-template='assets/images/icon-help'.Note
I left the filled icon in the masthead and in the input group because those are standalone-ish buttons.