feat(notificationdrawer): add recommendation option - #3338
Conversation
| | `.pf-m-warning` | `.pf-c-notification-drawer__list-item` | Modifies a notification list item for the warning state. | | ||
| | `.pf-m-danger` | `.pf-c-notification-drawer__list-item` | Modifies a notification list item for the danger state. | | ||
| | `.pf-m-success` | `.pf-c-notification-drawer__list-item` | Modifies a notification list item for the success state. | | ||
| | `.pf-m-recommendation` | `.pf-c-notification-drawer__list-item` | Modifies a notification list item for the recommendation state. | |
There was a problem hiding this comment.
Just want to verify this should be called pf-m-recommendation over pf-m-default?
There was a problem hiding this comment.
@megan-hall @mceledonia @mcarrano what are your thoughts here?
There was a problem hiding this comment.
Thanks for flagging this @mcoker . Even though 'recommendation' conforms to the OpenShift use case, we don't use that term elsewhere in PatternFly. We defined the teal alert state as 'default' that can be used for anything that the consumer wants. Can we call it 'pf-m-default'?
| {{/notification-drawer-list-item-header-title}} | ||
| {{/notification-drawer-list-item-header}} | ||
| {{#> notification-drawer-list-item-action}} | ||
| {{#> dropdown id=(concat notification-drawer--id "-action2") dropdown-menu--modifier="pf-m-align-right" dropdown--IsActionMenu="true" dropdown-toggle--modifier="pf-m-plain" dropdown--HasKebabIcon="true" aria-label="Actions"}}{{/dropdown}} |
There was a problem hiding this comment.
duplicate ID notification-drawer--id "-action2"
|
Preview: https://patternfly-pr-3338.surge.sh A11y report: https://patternfly-pr-3338-coverage.surge.sh
|
|
Looks good! Just a couple of things. |
4 participants
closes #3312