Skip to content

Compass sections - consider semantic elements #7940

Description

@mcoker

#7927 (comment)

So I'm wondering whether some of these components should use their semantic elements (footer element here, and header and main elsewhere).

Issue is the compass__panel components living outside header, footer, and main. I'm not sure if putting them in aside elements would make the most sense (they sorta do I think).

Probably fine to leave them as plain divs for now, but worth mulling over some more, especially because I assume we need (or at least want) the structure of Compass to be as it is now: header, panel, main, panel, and footer all being adjacent siblings (rather than main containing the 2 panels).


Jira Issue: PF-2878

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    PF TeamIssue originates from PF TeamStale

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions