Skip to content

Commit 4591e55

Browse files
fix(label): address review feedback
- remove unneeded whitespace control (~) from label-icon--map - fix duplicate label--id on the teal notification label
1 parent 9ca2c69 commit 4591e55

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{{#if label-icon--value}}
2-
{{~pfIcon label-icon--value}}
2+
{{pfIcon label-icon--value}}
33
{{else}}
4-
{{~#ifEquals label--status "success"}}{{pfIcon "rh-ui-check-circle-fill"}}{{/ifEquals}}
5-
{{~#ifEquals label--status "warning"}}{{pfIcon "rh-ui-warning-fill"}}{{/ifEquals}}
6-
{{~#ifEquals label--status "danger"}}{{pfIcon "rh-ui-error-fill"}}{{/ifEquals}}
7-
{{~#ifEquals label--status "info"}}{{pfIcon "rh-ui-information-fill"}}{{/ifEquals}}
8-
{{~#ifEquals label--status "custom"}}{{pfIcon "rh-ui-notification-fill"}}{{/ifEquals}}
4+
{{#ifEquals label--status "success"}}{{pfIcon "rh-ui-check-circle-fill"}}{{/ifEquals}}
5+
{{#ifEquals label--status "warning"}}{{pfIcon "rh-ui-warning-fill"}}{{/ifEquals}}
6+
{{#ifEquals label--status "danger"}}{{pfIcon "rh-ui-error-fill"}}{{/ifEquals}}
7+
{{#ifEquals label--status "info"}}{{pfIcon "rh-ui-information-fill"}}{{/ifEquals}}
8+
{{#ifEquals label--status "custom"}}{{pfIcon "rh-ui-notification-fill"}}{{/ifEquals}}
99
{{/if}}

‎src/patternfly/demos/Card/templates/card-demo--notification-drawer.hbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
label-text--value="3"
3131
label-icon--value="rh-ui-information-fill"}}
3232
{{> label
33-
label--id="default-blue-icon"
33+
label--id="default-teal-icon"
3434
label--color="teal"
3535
label-text--value="3"
3636
label-icon--value="rh-ui-notification-fill"}}

0 commit comments

Comments
 (0)