Small optimization of zero hashCode#58
Closed
TangBean wants to merge 1 commit into
Closed
Conversation
Owner
|
Hi @TangBean and thanks for the PR! Looking at the implementation of and
The Update: Just for the funs: ChatGPT 4 agrees with me: |
Owner
|
Anyway, thanks for the hint about the overall feature, I found out it can be quite buggy because there are no gurantees that the inner byte array is not mutatetduring the life of an Bytes instance, so I removed the feature all toghther: #59 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Small optimization of zero hashCode: Cache if the hash has been calculated as actually being zero, enabling us to avoid recalculating this.