Fix SIGTERM handling and add missing psr/log dependency - #51
Merged
Merged
Conversation
The SIGTERM handler was registered but never executed, because async signals were not enabled. It only worked inside Symfony console commands, where the SignalRegistry enables them as a side effect. psr/log is used directly but was only installed through dev dependencies.
DanielBadura
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SIGTERM listener registered its handler with pcntl_signal, but async signals were never enabled and pcntl_signal_dispatch was never called, so the handler didn't run. It only worked inside Symfony console commands because the console SignalRegistry enables async signals as a side effect. The listener now enables them itself, and there is a test that sends SIGTERM to the process.
psr/log is used directly (LoggerInterface, NullLogger as default in create) but was only pulled in through dev dependencies, so it is now a regular requirement. I also added ext-pcntl to suggest.
Two small fixes on the side: the memory limit log message said "512.0 MiB bytes", and the Worker::run docblock claimed microseconds instead of milliseconds.