Skip to content

Update critical dependencies and simplify the build step #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcothenet merged 2 commits into from
Dec 6, 2022
Merged

Update critical dependencies and simplify the build step #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55cfe85
Update dep and simplify build
pcothenet Dec 6, 2022
17e4076
Bump version
pcothenet Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
FROM node:16.13 AS base


FROM base AS build

WORKDIR /data
ENTRYPOINT [ "npm", "install"]


FROM base AS lint
FROM node:16.16 AS base

WORKDIR /data

ENTRYPOINT [ "npx", "prettier", "--write" ]
ENTRYPOINT []

9 changes: 5 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ SHELL = /bin/bash
build: install lint

install:
docker build --target build . -t patch-node-build && \
docker run --rm -v $(PWD):/data patch-node-build
docker build . -t patch-node-build && \
docker run --rm -v $(PWD):/data patch-node-build npm install
docker run --rm -v $(PWD):/data patch-node-build npm audit fix

lint:
docker build --target lint . -t patch-node-lint && \
docker run --rm -v $(PWD):/data patch-node-lint .
docker build . -t patch-node-build && \
docker run --rm -v $(PWD):/data patch-node-build npx prettier --write .

test:
npm run test
Expand Down
Loading