Fix: Backport of casing fixes#702
Merged
RyanClark2k merged 2 commits intoApr 7, 2023
Merged
Conversation
RyanClark2k
approved these changes
Apr 7, 2023
RyanClark2k
left a comment
RyanClark2k
left a comment
There was a problem hiding this comment.
This seems safe considering it's a backport and it's passing the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
Backport of:
Fix casing in type_of_union for union types #698
Fix casing in self._type for union types #692
==COMMIT_MSG==
Possible downsides?