Implemented Frame Icon - #25
Merged
Merged
Conversation
Added simple frame icon to replace default swing frame icon. This icon is just a place holder and can be change later.
pH-7
reviewed
Oct 8, 2018
Owner
|
Awesome @SidaDan 💯 |
Contributor
Author
|
Hi,
yes, you can remove it.
Greeting Frank
From: ♚ PH⑦ Soria ♛
Sent: Monday, October 08, 2018 11:29 AM
To: pH-7/Simple-Java-Text-Editor
Cc: Frank Schultz ; Mention
Subject: Re: [pH-7/Simple-Java-Text-Editor] Implemented Frame Icon (#25)
@pH-7 commented on this pull request.
--------------------------------------------------------------------------------
In src/simplejavatexteditor/UI.java:
@@ -93,6 +93,14 @@
private boolean edit = false;
public UI() {
+ try {
+ ImageIcon image = new ImageIcon("icons/ste.png");
+ super.setIconImage(image.getImage());
+ } // try
Is there a reason..., or can you remove the // try comment?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Reason: So we can work with larger text. Also remove redundant try comment.
Owner
|
Thanks very much @SidaDan Have a wonderful day!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello :-)
I have another small contribution for you, hope you find this
usefull.
Frank