Skip to content

fix: 🐛 Diagnose Windows file ancestors before missing paths - #86

Merged
oxspan merged 1 commit into
developfrom
feature/75-windows-path
Nov 12, 2026
Merged

oxspan merged 1 commit into
developfrom
feature/75-windows-path

Conversation

@oxspan

@oxspan oxspan commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Windows reports a child of a regular file as NoSuchFileException. Capture and inspect therefore advised creating a missing directory even though a file blocked the path. Validate the lexical parent before reporting a missing path, so nested file ancestors receive the existing not-a-directory guidance while genuinely missing directories retain their existing message.

The correction adds one line and preserves error codes, integrity checks, existing contents and genuine filesystem failures. No tests were changed, weakened or skipped. The existing three CapturePathTest cases fail before the change and pass afterward on native Windows, covering both capture formats and resume paths.

Validation:

  • Complete hosted Linux and Windows suites and native command package verification pass for the exact head in run 43251124659. Required PR CI also passes.
  • Line coverage 95.35% and branch coverage 81.08%, with unchanged thresholds.
  • Both ZIP checksums verify; Linux and Windows share byte-identical JVM payloads. The downloaded Windows executable passes version, redirected help, argument-error, invalid/missing-path and read-only grouped inspection checks; capture bytes remain unchanged.

Release-readiness run 43247008118 exposed the original Windows failure. No master promotion, release publication or version change is included.

Refs #75

@github-actions

Copy link
Copy Markdown
Contributor

Linux CI: success · Commit 198a22d

Test results (Linux)

Total Passed Failed Errors Skipped
289 289 0 0 0

Test coverage

Metric Covered / total Coverage Minimum Result
LINE 2278 / 2389 95.35% 90.00% PASS
BRANCH 1371 / 1691 81.08% 80.00% PASS

Includes the test JVM and CLI subprocesses. Excludes optional real-Collector smoke tests.

Workflow logs and report artifacts

Updated on each CI run. Windows checks, when required, are reported separately in the workflow.

@oxspan
oxspan merged commit df26cd3 into develop Nov 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant