Repository navigation
fix: 🐛 Diagnose Windows file ancestors before missing paths - #86
Merged
Merged
Conversation
Contributor
|
Linux CI: success · Commit Test results (Linux)
Test coverage
Includes the test JVM and CLI subprocesses. Excludes optional real-Collector smoke tests. Workflow logs and report artifacts Updated on each CI run. Windows checks, when required, are reported separately in the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows reports a child of a regular file as
NoSuchFileException. Capture and inspect therefore advised creating a missing directory even though a file blocked the path. Validate the lexical parent before reporting a missing path, so nested file ancestors receive the existing not-a-directory guidance while genuinely missing directories retain their existing message.The correction adds one line and preserves error codes, integrity checks, existing contents and genuine filesystem failures. No tests were changed, weakened or skipped. The existing three CapturePathTest cases fail before the change and pass afterward on native Windows, covering both capture formats and resume paths.
Validation:
Release-readiness run 43247008118 exposed the original Windows failure. No master promotion, release publication or version change is included.
Refs #75