Repository navigation
fix: 🐛 Validate reported Collector time zones - #85
Merged
Merged
Conversation
Contributor
|
Linux CI: success · Commit Test results (Linux)
Test coverage
Includes the test JVM and CLI subprocesses. Excludes optional real-Collector smoke tests. Workflow logs and report artifacts Updated on each CI run. Windows checks, when required, are reported separately in the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Collector runs in KST, declaring the same instants as a Los Angeles storage day can return an empty successful stream.
doctorandcollector statusnow expose the reported JVM time-zone ID and the CLI-derived UTC offset at the Collector's clock time, with explicit provenance. Online XLog search, capture, counter history and counter export reject differing offsets withINVALID_ARGUMENTbefore streams or capture writes; equivalent offsets remain accepted, including historical/DST interval checks.The ID comes from the existing authenticated
SERVER_ENVresponse, and the offset uses client JDK rules. Missing/unparseable metadata remains unknown. This does not certify the Collector's runtime default, TZDB or fixed-day storage calendar. Storage-date verification remains unverified, and capture schemas remain unchanged. English and Korean guides explain these limits.Validation: the complete Gradle regression suite passes, line coverage 95.35% and branch coverage 81.11%; release-input checks pass. The 22 new packaged CLI/zone-rule cases also pass on native Windows Java 21. Regression tests fail against the previous CLI and with deliberately broken fallback/DST handling. Actual Java 8 Collector 2.21.3 KST/LA/KST queries change from 3/0/3 records to 3/error2/3; v3 profile capture bytes match the previous CLI and remain readable by its strict reader.
Refs #57