Repository navigation
fix: 🐛 Retry denied Windows file replacements - #81
Merged
Merged
Conversation
Contributor
|
Linux CI: success · Commit Test results (Linux)
Test coverage
Includes the test JVM and CLI subprocesses. Excludes optional real-Collector smoke tests. Workflow logs and report artifacts Updated on each CI run. Windows checks, when required, are reported separately in the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Windows process holding a capture manifest can make atomic replacement fail with
AccessDeniedException, leaving a partial file and an intact previous checkpoint. File and Collector transport failures also shared one ambiguous message.Refs #58
Changes
Validation
AccessDeniedExceptionwhen retry was removed, then passed after restoring it.Compatibility and limits
Only Windows
AccessDeniedExceptionduring replacement is retried. It can also indicate permanent permissions problems; persistent denial still fails. The controlled file-handle case is reproduced, but the original intermittent incident and any antivirus/indexer involvement remain unconfirmed. New Windows tests used files in the repository through WSL UNC access; they do not establish NTFS-specific failure frequency. No release is published by this PR.