Migrate from URL to URI#200
Open
rodion-goritskov wants to merge 3 commits intoopenstack4j:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
I ran into a problem when using Openstack4j via Jenkins openstack-cloud-plugin.
My OpenStack provider has some services with non-HTTP endpoints (wss://, notably) registered in the catalog, so openstack4j fails to deserialize such endpoints when deserializing it.
The only way to mitigate this issue is to migrate from the URL to URI.
I performed such a change and tested the result when using the openstack-cloud-plugin - everything is working fine.
However, it changes the contract a little - if it is critical, I can add some overloads to maintain backward compatibility.