add (Neutron) qos policy bandwidth limit rule extension. #112
Open
bboyHan wants to merge 1 commit intoopenstack4j:mainfrom
Open
add (Neutron) qos policy bandwidth limit rule extension. #112bboyHan wants to merge 1 commit intoopenstack4j:mainfrom
bboyHan wants to merge 1 commit intoopenstack4j:mainfrom
Conversation
olivergondza
requested changes
Feb 11, 2021
Member
olivergondza
left a comment
olivergondza
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I have added 2 minor change requests.
| * | ||
| * @return direction | ||
| */ | ||
| String getDirection(); |
Member
There was a problem hiding this comment.
Would be cleaner to have an enum for the 2 valid values.
| /** | ||
| * @return the Networking (Neutron) Qos Policy Bandwidth Limit Rule Extension API | ||
| */ | ||
| NetQosPolicyBLRuleService netQosPolicyBandWidthLimitRule(); |
Member
There was a problem hiding this comment.
Please unify the BandWidth/Bandwidth spelling. Latter is better imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
done it. #111