Fix annotation handling in LombokValToFinalVar - #1237
Merged
greg-at-moderne merged 1 commit intoSep 11, 2026
Conversation
Contributor
Author
greg-at-moderne
self-requested a review
September 11, 2026 07:13
greg-at-moderne
approved these changes
Sep 11, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
Contributor
|
The CI failure seems unrelated. Yet I fail to understand why it would be happening in this branch, but not happening in |
Contributor
|
OK. I think I get it. The branch is in the fork (understandably) and we don't want to share Code Genome secrets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the replacement
varidentifier, the recipe usedAnnotationService.getAllAnnotations(getCursor()). At that point the cursor is on theJ.VariableDeclarations, so this returns the annotations of the whole declaration (e.g. a@SuppressWarnings("unchecked")on the statement), not the annotations attached to the type expression. Those declaration-level annotations were then attached to the newvaridentifier as well, leaving them printed twice.This takes the annotations from the type expression itself instead, which is what the new type identifier should carry over. Declaration-level annotations stay where they already are on the
J.VariableDeclarations.Added a test covering
@SuppressWarnings("unchecked")on avaldeclaration.🤖 Generated with Claude Code