This repository was archived by the owner on Jan 1, 2020. It is now read-only.
Store entities instead of objects#40
Merged
Merged
Conversation
Collaborator
|
Hi, thanks for the update, unittests look good, so I'll merge it. We probably should note the API change somewhere, but we're since we're not at 1.0 yet, I guess we can let implementors find this out on their own :-) |
flack
added a commit
that referenced
this pull request
Dec 6, 2012
Store entities instead of objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RdfMapperInterface could store instances of EntityInterface instead of objects. This will add a lot of convenience into finalization of #28.
Besides, it is really easy to get the object from the an entity, with the getObject() method.
CC @dbu