openpsa · flack · Dec 11, 2012 · Oct 11, 2012 · Oct 11, 2012 · Oct 27, 2012
diff --git a/src/Midgard/CreatePHP/Mapper/BaseDoctrineRdfMapper.php b/src/Midgard/CreatePHP/Mapper/BaseDoctrineRdfMapper.php
@@ -12,6 +12,8 @@
 use Doctrine\Common\Persistence\ManagerRegistry;
 use Midgard\CreatePHP\Entity\EntityInterface;
 
+use PHPCR\ItemExistsException;
+
 /**
  * Base mapper for doctrine, removing the proxy class names in canonicalClassName
  *
@@ -45,8 +47,14 @@ public function __construct($typeMap, ManagerRegistry $registry, $name = null)
      */
     public function store(EntityInterface $entity)
     {
-        $this->om->persist($entity);
-        $this->om->flush();
+        try {
+            $this->om->persist($entity->getObject());
+            $this->om->flush();
+        } catch (ItemExistsException $iee) {
+            //an item with the same title already exists
+            return false;
+        }
+
         return true;
     }
 

diff --git a/src/Midgard/CreatePHP/Mapper/DoctrinePhpcrOdmMapper.php b/src/Midgard/CreatePHP/Mapper/DoctrinePhpcrOdmMapper.php
@@ -11,6 +11,9 @@
 use Doctrine\Common\Persistence\ManagerRegistry;
 
 use Midgard\CreatePHP\Type\TypeInterface;
+use Midgard\CreatePHP\Entity\EntityInterface;
+
+use \RuntimeException;
 
 /**
  * Mapper to handle PHPCR-ODM.
@@ -20,27 +23,128 @@
  */
 class DoctrinePhpcrOdmMapper extends BaseDoctrineRdfMapper
 {
+
+    /**
+     * {@inheritDoc}
+     */
     public function prepareObject(TypeInterface $type, $parent = null)
     {
         $object = parent::prepareObject($type);
-        if (null !== $parent) {
-            /** @var $meta \Doctrine\ODM\PHPCR\Mapping\ClassMetadata */
-            $meta = $this->om->getClassMetaData(get_class($object));
-            $meta->setFieldValue($object, $meta->parentMapping, $parent);
+        if (null == $parent) {
+            throw new RuntimeException('You need a parent to create new objects');
         }
+
+        /** @var $meta \Doctrine\ODM\PHPCR\Mapping\ClassMetadata */
+        $meta = $this->om->getClassMetaData(get_class($object));
+
+        if (!property_exists($object, $meta->parentMapping)) {
+            throw new RuntimeException('parentMapping need to be mapped to '
+                . get_class($object));
+        }
+
+        $meta->setFieldValue($object, $meta->parentMapping, $parent);
+
         return $object;
     }
 
+    /**
+     * Overwrite to set the node name if not set
+     *
+     * @param EntityInterface $entity
+     * @return bool|void
+     */
+    public function store(EntityInterface $entity)
+    {
+        /** @var $meta \Doctrine\ODM\PHPCR\Mapping\ClassMetadata */
+        $meta = $this->om->getClassMetaData(get_class($entity->getObject()));
+
+        if (!property_exists($entity->getObject(), $meta->nodename)) {
+            throw new RuntimeException('nodename need to be mapped to '
+                . get_class($entity->getObject()));
+        }
+
+        $nodename = $meta->getFieldValue($entity->getObject(), $meta->nodename);
+
+        if (empty($nodename)) { //in case of node creation the nodename is empty
+            $name = $this->generateNodeName($entity);
+            //set a guessed nodename
+            $meta->setFieldValue($entity->getObject(), $meta->nodename, $name);
+        }
+
+        return parent::store($entity);
+    }
+
     /**
      * {@inheritDoc}
      */
-    public function getBySubject($subject) {
+    public function getBySubject($subject)
+    {
         if (empty($subject)) {
-            throw new \RuntimeException('Subject may not be empty');
+            throw new RuntimeException('Subject may not be empty');
         }
         $ret = $this->om->find(null, $subject);
-        if (empty($ret)) throw new \RuntimeException("Not found: $subject");
+        if (empty($ret)) throw new RuntimeException("Not found: $subject");
         return $ret;
     }
 
-}
+    /**
+     * Generate an URL friendly node name from an entity
+     * Find a usable property and remove spaces, accents and special chars
+     *
+     * @param EntityInterface $entity
+     * @return mixed|string
+     */
+    protected function generateNodeName(EntityInterface $entity)
+    {
+        $title = $this->determineEntityTitle($entity);
+
+        //TODO: find a better way? For example with Doctrine_Inflector or Gedmo\Sluggable\Util\Urlizer
+        setlocale(LC_CTYPE, 'en_US.UTF8');
+        $title = iconv('UTF-8', 'ASCII//TRANSLIT//IGNORE', $title);
+        $title = trim($title, "\x00..\x1F");
+        $title = preg_replace('/[^a-z0-9A-Z_.]/', '-', $title);
+
+        return $title;
+    }
+
+    /**
+     *
+     * Determine the title of the entity to be created, following this logic:
+     *
+     * 1. is there a getTitle method with a value set
+     * 2. is there a property containing "title" in rdf definition
+     * 3. take the first property defined in rdf and take first 50 characters
+     * 4. give up
+     *
+     * @param EntityInterface $entity
+     */
+    private function determineEntityTitle(EntityInterface $entity)
+    {
+        $object = $entity->getObject();
+
+        //is there a getTitle method?
+        if (method_exists($object, 'getTitle') && $object->getTitle() !== '') {
+            return $object->getTitle();
+        } else {
+            //try to get a property containing title in the rdf description
+            foreach ($entity->getChildDefinitions() as $node) {
+                if (!($node instanceof \Midgard\CreatePHP\Entity\PropertyInterface) ||
+                    strpos($node->getProperty(), "title") === false) {
+                    continue;
+                }
+                return $entity->getMapper()->getPropertyValue($object, $node);
+            }
+
+            //try to get the first property to create a guessed title of max 50 characters
+            foreach ($entity->getChildDefinitions() as $node) {
+                if (!$node instanceof \Midgard\CreatePHP\Entity\PropertyInterface) {
+                    continue;
+                }
+                return substr($entity->getMapper()->getPropertyValue($object, $node), 0, 49);
+            }
+
+            //give up
+            throw new RuntimeException('No title could be found four your new node.');
+        }
+    }
+}
diff --git a/src/Midgard/CreatePHP/RestService.php b/src/Midgard/CreatePHP/RestService.php
@@ -16,6 +16,8 @@
 use Midgard\CreatePHP\Entity\EntityInterface;
 use Midgard\CreatePHP\Entity\PropertyInterface;
 
+use Midgard\CreatePHP\Helper\NamespaceHelper;
+
 /**
  * @package Midgard.CreatePHP
  */
@@ -119,6 +121,7 @@ public function getMapper()
      */
     public function run($data, TypeInterface $type, $subject = null, $method = null)
     {
+
         if (null === $method) {
             $method = strtolower($_SERVER['REQUEST_METHOD']);
         }
@@ -152,32 +155,29 @@ public function run($data, TypeInterface $type, $subject = null, $method = null)
     /**
      * Handle post request
      *
+     * Find a reverse mapping to the parent, into received data and type
+     * reverse options. The mapping is used to create the entity to store.
+     *
      * @param array $received_data
-     * @param TypeInterface $type parent node of this type (TODO: refactor)
+     * @param TypeInterface $type type of the node to create
+     * @return array|null
      */
     private function _handleCreate($received_data, TypeInterface $type)
     {
-        foreach ($type->getChildDefinitions() as $node) {
-            if (!$node instanceof CollectionDefinitionInterface) {
-                continue;
-            }
-            $types = $node->getTypes();
-            if (count($types) != 1) {
-                throw new \Exception('TODO: refactor creation');
-            }
-            /** @var $node CollectionDefinitionInterface */
-            $child_type = reset($types);
-            $parentfield = $this->_expandPropertyName($node->getRev(), $child_type);
-            if (!empty($received_data[$parentfield])) {
-                $parent_identifier = $this->jsonldDecode($received_data[$parentfield][0]);
-                $parent = $this->_mapper->getBySubject($parent_identifier);
-                $object = $this->_mapper->prepareObject($child_type, $parent);
-                $entity = $child_type->createWithObject($object);
-                return $this->_storeData($received_data, $entity);
+        $parent = null;
+        foreach ($type->getRevOptions() as $option) {
+            $rdf = NamespaceHelper::expandNamespace($option, $type->getVocabularies());
+            $about = $received_data[$this->jsonldEncode($rdf)];
+
+            if (! empty($about)) {
+                $parent = $this->_mapper->getBySubject($this->jsonldDecode(current($about)));
+                break;
             }
         }
-        $object = $this->_mapper->prepareObject($type);
+
+        $object = $this->_mapper->prepareObject($type, $parent);
         $entity = $type->createWithObject($object);
+
         return $this->_storeData($received_data, $entity);
     }
 

diff --git a/tests/Test/Midgard/CreatePHP/RestServiceTest.php b/tests/Test/Midgard/CreatePHP/RestServiceTest.php
@@ -151,8 +151,13 @@ public function testRunPost()
         ;
 
         $this->type->expects($this->any())
-            ->method('getChildDefinitions')
-            ->will($this->returnValue(array('title' => $this->property, 'children' => $this->collection)))
+            ->method('getRevOptions')
+            ->will($this->returnValue(array('dcterms:partOf')))
+        ;
+
+        $this->type->expects($this->any())
+            ->method('createWithObject')
+            ->will($this->returnValue($this->entity))
         ;
 
         $rest = new RestService($this->mapper);