You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What does this PR implement/fix? Explain your changes.
Removes the repeated calls to openml.runs.get_runs and replaces it with one single API call using openml.evaluations.list_evaluations_setups.
Also, added a unit test for this example.
However, could you please explain why you need an extra test given that the example is executed by travis-ci?
I came across the issue #805 and thought this was a good opportunity to incorporate it. Also, I came across a unit test for the SVM example. Hence, I thought this was the protocol.
Having the example as a unit test also seemed to be a good check since from what I understand, we won't know if the example script failed, in terms of an error from travis-ci, will we? That is, we might still get all greens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Addresses #852.
What does this PR implement/fix? Explain your changes.
Removes the repeated calls to
openml.runs.get_runsand replaces it with one single API call usingopenml.evaluations.list_evaluations_setups.Also, added a unit test for this example.