Repository navigation
Prefer lazy loading in unit tests - #655
Merged
Merged
Conversation
Collaborator
Author
|
Same fails as #654, see that PR. |
Codecov Report
@@ Coverage Diff @@
## develop #655 +/- ##
===========================================
- Coverage 90.96% 90.93% -0.03%
===========================================
Files 32 32
Lines 3388 3388
===========================================
- Hits 3082 3081 -1
- Misses 306 307 +1
Continue to review full report at Codecov.
|
mfeurer
approved these changes
Apr 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer lazy loading for all unit tests that don't explicitly need the arff file.
Incremental progress towards #330.
I don't think it matters much for most unit tests (many call
get_dataafter downloading the data regardless), but it helps for some and otherwise hopefully encourages future additions to think about lazily loading data :)If there are any other suggestions that should be included in the PR I'd like to hear them.