Repository navigation
Pep8 enforce - #535
Merged
Merged
Pep8 enforce#535
Conversation
* CI: add flake8 check in travis * FIX: typo
mfeurer
reviewed
Sep 20, 2018
mfeurer
left a comment
mfeurer
left a comment
Collaborator
There was a problem hiding this comment.
This looks very good. However, there are some comments specific to scikit-learn in the file flake8_diff.sh, could you please remove them? Also, could you please add a comment to the top of the file to highlight its origin?
Member
Author
|
@mfeurer oops my bad. Good points. |
Member
Author
mfeurer
approved these changes
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement/fix? Explain your changes.
Enforces the Pep8 style guide.
How should this PR be tested?
Not easily done with unit tests.
Any other comments?