Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #340 +/- ##
===========================================
- Coverage 89.72% 89.61% -0.11%
===========================================
Files 32 32
Lines 2510 2513 +3
===========================================
Hits 2252 2252
- Misses 258 261 +3
Continue to review full report at Codecov.
|
Collaborator
Author
|
No, they're not. But I don't know them and I don't know what happens in case of them. I only added this specific error message because I realized that it could be improved in that special case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #218 was actually fixed in #253, however, #253 didn't add a unit test. This PR adds the missing unit test.