Skip to content

Remove dataset pickles - #336

Merged
mfeurer merged 6 commits into
openml:developfrom
amueller:remove_dataset_pickles
Oct 11, 2017
Merged

mfeurer merged 6 commits into
openml:developfrom
amueller:remove_dataset_pickles

Conversation

@amueller

@amueller amueller commented Oct 9, 2017 •

Copy link
Copy Markdown
Contributor

Includes #333.
Fixes #331 (I think).

@amueller
amueller changed the base branch from master to develop October 9, 2017 15:00
@amueller amueller closed this Oct 9, 2017
@amueller amueller reopened this Oct 9, 2017
* do not delete pickle while trying to load data
* do tests for datasets in separate directories
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #336 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #336      +/-   ##
===========================================
- Coverage    89.73%   89.69%   -0.05%     
===========================================
  Files           32       32              
  Lines         2514     2522       +8     
===========================================
+ Hits          2256     2262       +6     
- Misses         258      260       +2
Impacted Files Coverage Δ
openml/runs/functions.py 87.4% <ø> (-0.55%) ⬇️
openml/datasets/functions.py 90.04% <ø> (-0.69%) ⬇️
openml/datasets/dataset.py 78.85% <0%> (+0.44%) ⬆️
openml/tasks/functions.py 85.89% <0%> (-0.67%) ⬇️
openml/evaluations/functions.py 91.89% <0%> (+1.64%) ⬆️
openml/setups/functions.py 93.06% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd3dbd...af1de06. Read the comment docs.

@mfeurer
mfeurer merged commit 40510b9 into openml:develop Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants