Skip to content

Dont ignore pickles - #333

Merged
mfeurer merged 1 commit into
openml:developfrom
amueller:dont_ignore_pickles
Oct 9, 2017
Merged

mfeurer merged 1 commit into
openml:developfrom
amueller:dont_ignore_pickles

Conversation

@amueller

@amueller amueller commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@amueller
amueller changed the base branch from master to develop October 9, 2017 14:33
@codecov-io

codecov-io commented Oct 9, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #333 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #333   +/-   ##
========================================
  Coverage    89.72%   89.72%           
========================================
  Files           32       32           
  Lines         2510     2510           
========================================
  Hits          2252     2252           
  Misses         258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2448826...2bb18b4. Read the comment docs.

@amueller amueller mentioned this pull request Oct 9, 2017

@mfeurer mfeurer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense if we remove the pickles.

@amueller

amueller commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

I don't understand the failure in this branch @mfeurer.... hm

@amueller

amueller commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

it looks like travis runs against the wrong PR?!

@amueller amueller closed this Oct 9, 2017
@amueller amueller reopened this Oct 9, 2017
@amueller amueller closed this Oct 9, 2017
@amueller amueller reopened this Oct 9, 2017
@amueller
amueller force-pushed the dont_ignore_pickles branch from a212d3f to 2bb18b4 Compare October 9, 2017 16:06
@mfeurer
mfeurer merged commit 6c25b86 into openml:develop Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants