Repository navigation
Conversation
fix line 35 in functions.py to avoid add dataset_id -1
Author
|
Already fix! please build again. |
datasets number is not sure for different release, not empty is OK
Number of datasets is not fixed, not empty is OK
Member
|
Hi @omgteam thanks for adding this fix to the package! The lead developer of the package is currently on holiday, but I will ask him to merge this change after he comes back (~in two weeks) Please let us know if there is any way we can help you with in the meantime |
mfeurer
added a commit
that referenced
this pull request
Mar 27, 2017
Collaborator
|
I assume this PR is about fixing issue #189, is this correct? |
janvanrijn
added a commit
that referenced
this pull request
Apr 6, 2017
FIX issue #189, delete cached dataset after test
Collaborator
|
I'm closing this now because of inactivity. Please reopen this pull request if you believe that your issue wasn't fixed in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix line 35 in functions.py to avoid add dataset_id -1, which cause test error when python setup.py install
Due to re.match error in openml/datasets/functions.py line35, self.assertEqual(len(cached_datasets), 2) in openml-python/tests/test_datasets/test_dataset_functions.py will pop error when python setup.py test.
Error:
FAIL: test__list_cached_datasets (tests.test_datasets.test_dataset_functions.TestOpenMLDataset)
Traceback (most recent call last):
File "/root/install/openml-python/tests/test_datasets/test_dataset_functions.py", line 34, in test__list_cached_datasets
self.assertEqual(len(cached_datasets), 2)
nose.proxy.AssertionError: 3 != 2
'3 != 2' = '%s != %s' % _common_shorten_repr(3, 2)
'3 != 2' = self._formatMessage('3 != 2', '3 != 2')
Fix:
old:
if not re.match(r"[0-9]", directory_name): ##openml/datasets/functions.py in line 35
new:
if re.match(r"[0-9]", directory_name).group() == "":