Repository navigation
Migrate test_setups to pytest - #1442
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 53.99% 53.84% -0.16%
==========================================
Files 63 63
Lines 5230 5230
==========================================
- Hits 2824 2816 -8
- Misses 2406 2414 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PGijsbers
approved these changes
Oct 19, 2026
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
unittest.TestCase-based tests (openml.testing.TestBase) to pure pytest-style tests.TestSetupFunctionswith module-level test functions and introduces a pytest fixturesklearn_extension()to provide theSklearnExtensioninstance previously created insetUp()._existing_setup_exists()is extracted as a standalone function that acceptssklearn_extensionas a parameter.static_cache_dirfixture from conftest.py.assertandpytest.raises, consistent with the style already used in test_utils.py.TestBase._mark_entity_for_removal()andTestBase.loggerare preserved for tracking entities uploaded to the test server during cleanup.