Repository navigation
Verify ignore_attributes and row_id_attribute on create_dataset #964
Description
From #960.
When create_dataset is called, the user can specify ignored_attributes and row_id_attribute. These are attributes in the dataset which should be ignored when building models, because they represent e.g. an id field or a feature with label leakage. However, there is currently no check that the attributes listed are actually present in the data.
Using the dataset upload tutorial, if we overwrite row_id_attribute=None or ignore_attribute=None in the create_dataset calls to instead say row_id_attribute="not exist" or ignore_attribute="not exist" no error is raised, even though there is no "not exist" attribute in the dataset.
We expect either scenario to raise a ValueError clearly stating which id or ignored attribute is not present in the dataset.
Activity
joaquinvanschoren commentedon Oct 26, 2020
FYI, when you use
ignored_attributes="attribute1,attribute2"as a string, it will store "attribute1,attribute2" on the server, and not "attribute1","attribute2". That's no good. Hence, if one uses a comma-separated string instead of a list, it should either return an error or auto-parse and check if all attributes exist.PGijsbers commentedon Oct 26, 2020
I think this will automatically be caught if this issue is resolved, as the dataset will not have an attribute named
"attribute1,attribute2".a-moadel commentedon Oct 27, 2020
@PGijsbers I would like start working in this task.
PGijsbers commentedon Oct 29, 2020
#978 added client-side checks