ensure examples are unit tested #805

Activity

1. janvanrijn commented on Oct 8, 2019

   

   janvanrijn

   on Oct 8, 2019

   MemberAuthor

   More actions

   side-question. what happens if we execute first
   pip install -e '.test'
   and subsequently
   pip install -e '.examples'

   Will that include the installation of all dependencies of both commands and keep the package as is?
2. mfeurer commented on Oct 9, 2019

   

   mfeurer

   on Oct 9, 2019

   Collaborator

   More actions

   i think they might be, since one of the travis runs crashes when they are not properly handled.

   Yes, they're actually executed as part of building the documentation: https://github.com/openml/openml-python/blob/develop/ci_scripts/create_doc.sh#L24

   The travis script has several variables, including "examples". None of the travis runs invokes this variable. Is this good?

   This is not as bad as it sounds as there are no more "examples": https://github.com/openml/openml-python/blob/develop/ci_scripts/test.sh#L19 I'll remove those lines.

   Regarding your side question: I'm not sure, but I'd expect that the installation is skipped the second time. (and therefore the dependencies will not be installed).
3. mfeurer

   added a commit that references this issue on Oct 9, 2019

   React on issue #805

   ...

   1e93fb7
4. mfeurer commented on Oct 9, 2019

   

   mfeurer

   on Oct 9, 2019

   Collaborator

   More actions

   I just created #806 to remove these unnecessary variables.
5. mfeurer commented on Oct 20, 2020

   

   mfeurer

   on Oct 20, 2020

   Collaborator

   More actions

   Closing this as we test the examples (they constantly for one PR so I'm really sure about this) and removed the unused variable from the travis scripts. Please reopen if there's something else to this issue.

   👍React with 👍1Reacted by Pieter Gijsbers
6. mfeurer

   closed this as completedon Oct 20, 2020