Evaluate the usage of black for more automatic code formatting #781

Activity

1. PGijsbers commented on Apr 20, 2020

   

   PGijsbers

   on Apr 20, 2020

   Collaborator

   More actions

   I've been using black in GAMA now since a few weeks. The experience has been good so far. I also took the time to set up a pre-commit hook. Before doing any commit (locally), it will run black, mypy and flake8. The pre-commit has a few benefits:

   • You don't have to call black manually, so it can't be forgotten.
   • You won't have check-ins with flake8 and mypy errors, which means also no commits that are just "Fix Flake8/mypy". Keeps a cleaner commit history and puts less strain on CI servers.
   • If we add configuration files for each of those packages, alongside the pre-commit configuration, everyone runs the same version of the packages with the same configurations. There will be no need for manual setup beyond pre-commit install.

   Thoughts?

   It shouldn't take a long time to set up, and I'm willing to do that. But I won't have time for it until sometime in May.
2. mfeurer commented on Apr 20, 2020

   

   mfeurer

   on Apr 20, 2020

   CollaboratorAuthor

   More actions

   Thoughts?

   That sounds great.

   I'm willing to do that.

   That's great, too :)

   But I won't have time for it until sometime in May.

   Fine by me, I guess most of us are busy with the TPAMI SI anyway.

   👍React with 👍1Reacted by Pieter Gijsbers
3. PGijsbers

   self-assigned this

   on Apr 20, 2020
4. mfeurer commented on Jul 6, 2020

   

   mfeurer

   on Jul 6, 2020

   CollaboratorAuthor

   More actions

   This was added in #922
5. mfeurer

   closed this as completedon Jul 6, 2020