Skip to content

Duplicate information in task object #656

Closed
Closed
Duplicate information in task object#656

Description

@ArlindKadra
ArlindKadra
opened on Apr 1, 2019

openml-python/openml/tasks/task.py

Lines 204 to 205 in 7839225

self.estimation_procedure["parameters"] = estimation_parameters
self.estimation_parameters = estimation_parameters
See More

Line 205 adds duplicate information to the task object. The estimation procedure parameters are already stored in line 204.
Do we create a property on estimation_parameters and issue a future deprecation warning, so we can deprecate at a later time?

Activity

  1. mfeurer commented on Apr 1, 2019

    @mfeurer
    mfeurer
    on Apr 1, 2019
    Collaborator

    Yes, please go ahead and do so.

  2. ArlindKadra
    added 2 commits that reference this issue on Apr 4, 2019

    Addressing #656

    f711790

    Addressing #656

    3b847b2
  3. ArlindKadra
    added 2 commits that reference this issue on Apr 19, 2019

    Addressing #656

    81d419d

    Addressing #656

    6aff216
  4. mfeurer
    added a commit that references this issue on Apr 26, 2019

    [WIP] Task upload (#607)

    813daeb

  5. ArlindKadra commented on Apr 26, 2019

    @ArlindKadra
    ArlindKadra
    on Apr 26, 2019
    MemberAuthor

    Addressed in #607

  6. ArlindKadra
    closed this as completedon Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions