Separate interaction with API into a dedicated package #596

Activity

1. KOLANICH

   changed the title [-]API[/-] [+]Separate interaction with API into a dedicated package[/+] on Nov 27, 2018
2. nok commented on Nov 29, 2018

   

   nok

   on Nov 29, 2018

   More actions

   Which ones?
3. KOLANICH commented on Nov 30, 2018

   

   KOLANICH

   on Nov 30, 2018

   Author

   More actions

   openml-python/setup.py

   Line 47 in 7a612ea

   'oslo.concurrency',

   
   

   openml-python/setup.py

   Line 44 in 7a612ea

   'scikit-learn>=0.18',

   
   are used only in flows and are unneeded for fetching datasets via API. Though it may make sense to create a separate package dedicated to interaction wjth api with minimum of dependencies.

   See More

   openml-python/setup.py

   Line 45 in 7a612ea

   'nbformat',

   
   

   openml-python/setup.py

   Line 37 in 7a612ea

   'mock',

   
   are used only in tests and should be moved to
   

   openml-python/setup.py

   Line 50 in 7a612ea

   'test': [
4. nok commented on Dec 1, 2018

   

   nok

   on Dec 1, 2018

   More actions

   Yes, I agree. In addition the unit tests should be excluded for a release.
   https://github.com/openml/openml-python/blob/master/setup.py#L35
5. mfeurer commented on Dec 3, 2018

   

   mfeurer

   on Dec 3, 2018

   Collaborator

   More actions

   A few brief comments:

   • oslo.concurrency: Necessary to use the OpenML connector multiple times in parallel. However, if there are any better locking tools with less dependencies I'd be happy to accept a PR which changes this. I chose oslo back then because it's the successor of lockfile.
   • scikit-learn: I can see your point here, but for now this has the huge advantage of having lots of integration tests. Also, in my opinion this would create more short term work than benefits.
   • nbformat, mock and test: happy to accept a pull which moves them to test.
6. PGijsbers commented on Apr 15, 2019

   

   PGijsbers

   on Apr 15, 2019

   Collaborator

   More actions

   I agree it's important to take a look at which packages should be required, and which can be sorted in extra_requires or dropped altogether.
   Because there are multiple open issues with this sentiment, I will close all of them except for this one.
   Other issues which have a discussion on dependencies:

   • Running tests requires matplotlib #530
   • A large number of dependencies #531
7. PGijsbers

   self-assigned this

   on Apr 16, 2019
8. PGijsbers commented on Apr 16, 2019

   

   PGijsbers

   on Apr 16, 2019

   Last edited by PGijsbers

   Collaborator

   More actions

   Test-only dependencies have now been marked as such. When installing openml-python, by default oslo.concurrency is no longer a dependency. See #675.
9. PGijsbers

   closed this as completedon Apr 16, 2019