Skip to content

Extra information saved, Duplicate code #587

Closed
Closed
Extra information saved, Duplicate code#587
Assignees
ArlindKadra

Description

@ArlindKadra
ArlindKadra
opened on Nov 6, 2018

Description

OpenMLClassificationTask, OpenMLLearningCurveTask in task.py need a refactor. They save information which is already there by inheritance.
Edit.
It seems like the OpenMLLearningCurveTask should extend OpenMLClassificationTask and not OpenMLSupervisedTask.

openml-python/openml/tasks/task.py

Lines 144 to 151 in 7b81dae

target_name=target_name,
data_splits_url=data_splits_url,
)
self.target_name = target_name
self.class_labels = class_labels
self.cost_matrix = cost_matrix
self.estimation_procedure["data_splits_url"] = data_splits_url
self.split = None
See More

openml-python/openml/tasks/task.py

Lines 203 to 210 in 7b81dae

target_name=target_name,
data_splits_url=data_splits_url,
)
self.target_name = target_name
self.class_labels = class_labels
self.cost_matrix = cost_matrix
self.estimation_procedure["data_splits_url"] = data_splits_url
self.split = None

Activity

  1. ArlindKadra
    self-assigned this
    on Nov 6, 2018

  2. ArlindKadra commented on Nov 15, 2018

    @ArlindKadra
    ArlindKadra
    on Nov 15, 2018
    MemberAuthor

    Fixed in #588

  3. ArlindKadra
    closed this as completedon Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions