Skip to content

Improve dataset uploading #540

Closed
Closed
Improve dataset uploading#540
Assignees
ArlindKadra

Description

@mfeurer
mfeurer
opened on Sep 20, 2018

Reviewing PR #539 which tests dataset uploading, I found four things which we could improve to make dataset uploading nicer for the user:

  1. There should be no necessity to provide the format as this will always be 'arff'.
  2. The current example encodes the class label as a REAL, although it should actually be a categorical.
  3. We could add an example for uploading a list of lists, which could then also contain strings and categories.
  4. The function create_dataset should be imported into the openml.datasets namespace.

@ArlindKadra @glemaitre

Activity

  1. ArlindKadra
    self-assigned this
    on Sep 21, 2018

  2. mfeurer commented on Sep 21, 2018

    @mfeurer
    mfeurer
    on Sep 21, 2018
    CollaboratorAuthor

    After discussion with @ArlindKadra @joaquinvanschoren there are some more open points:

    1. we need to check if the data is sparse and change the data format accordingly.
    2. we need an example regarding the upload of sparse data
    3. we need a unit test regarding the upload of sparse data

  3. glemaitre commented on Sep 21, 2018

    @glemaitre
    glemaitre
    on Sep 21, 2018
    Contributor

    we need to check if the data is sparse and change the data format accordingly.

    Do you want to change the format depending if the user pass an array (dataframe) or a sparse array (dataframe)?

  4. mfeurer commented on Sep 21, 2018

    @mfeurer
    mfeurer
    on Sep 21, 2018
    CollaboratorAuthor

    Yes. Do you think that makes sense or do you think the user should decide that him/herself?

  5. glemaitre commented on Sep 21, 2018

    @glemaitre
    glemaitre
    on Sep 21, 2018
    Contributor

    I think this is OK. It is what I did in the loading stage #548

  6. amueller commented on Sep 26, 2018

    @amueller
    amueller
    on Sep 26, 2018
    Contributor

    is create_datasets listed in the api docs? I can't see any docs on uploading datasets at all :-/

  7. ArlindKadra commented on Sep 26, 2018

    @ArlindKadra
    ArlindKadra
    on Sep 26, 2018 via email
    Member

  8. amueller commented on Sep 26, 2018

    @amueller
    amueller
    on Sep 26, 2018
    Contributor

    ah, I was looking at /dev/

  9. amueller commented on Sep 26, 2018

    @amueller
    amueller
    on Sep 26, 2018
    Contributor

    even more off-topic: is there a reason the example gallery is not in the top level menu and that progress and changelog link to the same thing?

  10. amueller commented on Sep 26, 2018

    @amueller
    amueller
    on Sep 26, 2018
    Contributor

    the create_dataset is still missing from the API docs

  11. amueller commented on Sep 26, 2018

    @amueller
    amueller
    on Sep 26, 2018
    Contributor

    #553 #554 #556

  12. mfeurer commented on Nov 16, 2018

    @mfeurer
    mfeurer
    on Nov 16, 2018
    CollaboratorAuthor

    This was fixed by #547

  13. mfeurer
    closed this as completedon Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions