get_task failing #538

Activity

1. ArlindKadra commented on Sep 20, 2018

   

   ArlindKadra

   on Sep 20, 2018

   MemberAuthor

   More actions

   input is not a list but a dictionary.
   

   openml-python/openml/tasks/functions.py

   Line 351 in 34c06df

   for input_ in dic["oml:input"]:

   See More
2. ArlindKadra commented on Oct 5, 2018

   

   ArlindKadra

   on Oct 5, 2018

   Last edited by ArlindKadra

   MemberAuthor

   More actions

   @janvanrijn @mfeurer I am trying to fix the issue above and I have a question regarding the current implementation of tasks.
   

   openml-python/openml/tasks/task.py

   Lines 10 to 20 in 811f9ce

   	class OpenMLTask(object):
   	def __init__(self, task_id, task_type_id, task_type, data_set_id,
   	estimation_procedure_type, estimation_parameters,
   	evaluation_measure):
   	self.task_id = int(task_id)
   	self.task_type_id = int(task_type_id)
   	self.task_type = task_type
   	self.dataset_id = int(data_set_id)
   	self.estimation_procedure = dict()
   	self.estimation_procedure["type"] = estimation_procedure_type
   	self.estimation_procedure["parameters"] = estimation_parameters

   The base class upon which all of the tasks are built, has estimation procedure as a mandatory field, with type and parameters. The above issue is happening because the tasks has only 1 input.

   Are clustering tasks supposed to have a mandatory estimation procedure field and the above an outlier which should be removed or I should change the implementation.

   The easiest fix for the second option, would be to have the common args like that for all the other tasks and to pass none for the estimation procedure for the clustering task, it would defeat the purpose of the base class on the other hand since it does not have the common arguments between all.
3. mfeurer commented on Oct 12, 2018

   

   mfeurer

   on Oct 12, 2018

   Collaborator

   More actions

   I think removing the estimation procedure from the base class and having it in the OpenMLSupervisedTask would be a clean solution.

   👍React with 👍1Reacted by Arlind Kadra
4. mfeurer commented on Dec 3, 2018

   

   mfeurer

   on Dec 3, 2018

   Collaborator

   More actions

   Fixed by #541.
5. mfeurer

   closed this as completedon Dec 3, 2018