Skip to content

No unit test for create_dataset #537

Closed

Description

@ArlindKadra

Description

def create_dataset(name, description, creator, contributor, collection_date,

Function does not have a unit test. Although an example usage is located into the develop docs.

Activity

  1. mfeurer commented on Sep 21, 2018

    @mfeurer
    Collaborator

    Fixed by #539.

  2. mfeurer commented on Sep 21, 2018

    @mfeurer
    Collaborator

    No, it's actually not...

  3. mfeurer commented on Sep 21, 2018

    @mfeurer
    Collaborator

    but I really don't think we need one as this is simply one function call.

  4. ArlindKadra commented on Sep 21, 2018

    @ArlindKadra
    MemberAuthor

    but I really don't think we need one as this is simply one function call.

    @mfeurer yes, but since we thought it would be the main way that a user would choose to create a dataset, I think it should be tested.

  5. ArlindKadra commented on Sep 21, 2018

    @ArlindKadra
    MemberAuthor

    @mfeurer sorry, I put a missleading title and function line.

  6. changed the title [-]No unit test for _create_dataset_from_description[/-] [+]No unit test for create_dataset[/+] on Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions