Skip to content

Running tests requires matplotlib #530

Closed

Description

@rth

As part of pytest migration in #527, it looks like matplotlib is hard dependency for running tests, despite what setup.py requirements, and CONTRIBUTING.md says.

It is imported in

but doesn't seem to be used (added in #430).

Is it required by nbformat?

An alternative could be to skip corresponding tests.

Activity

  1. mfeurer commented on Sep 20, 2018

    @mfeurer
    Collaborator

    We used to have a jupyter notebook as an example which used matplotlib. In the last few weeks, we replaced it by multiple small python examples and removed the plotting for the moment. The notebook was unit tested, and I guess we can remove that unit test for now. Do you want to create a PR for this?

  2. added
    Good First IssueIssues suitable for people new to contributing to openml-python!
    on Jan 15, 2019
  3. PGijsbers commented on Apr 15, 2019

    @PGijsbers
    Collaborator

    With many issues open on the same topic, I decided to close this one. All further discussion can be had in #596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good First IssueIssues suitable for people new to contributing to openml-python!

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions