Repository navigation
Do not leave files after running unit tests #447
Description
Currently, the unit tests leave a few files. This clutters the development directory and makes it harder to keep an overview in git.
{{ message }}
Currently, the unit tests leave a few files. This clutters the development directory and makes it harder to keep an overview in git.
Activity
rth commentedon Sep 17, 2018
That would be fairly straightforward with pytest #327
Neeratyoy commentedon Jun 24, 2019
Hi,
On taking a preliminary look at
openml/testing.py, thesetUp()andtearDown()does a neat job of creating a temp directory and cleaning it up. It works.However, all the excess files which show up untracked for git, are in the directory
test/files/.In that case, can I use
os.walk()before and after the testing, to look for new files that were not there in this directory and get them cleaned? If not, can someone just nudge me to see where and howtest/filesis getting updated?I do need to take a deeper look but pytest still seems to have a related open issue, so this might need some book-keeping and forced deletions.
mfeurer commentedon Jul 9, 2019
@Neeratyoy I'm afraid that the current implementation does not work, i.e. it changes the working directory before running the tests, executing the 2nd
git statusoutside of the git repository. Could you please create a new PR fixing this?Neeratyoy commentedon Jul 9, 2019
Sure, I'll take a look at this.
Neeratyoy commentedon Jul 9, 2019
@mfeurer could you please guide me as to how I can test this locally?
When I execute
bash ci_scripts/test.sh, or even checkecho $TEST_DIRat the beginning ofrun_tests(), it gives amkdir: missing operanderror. The result ofecho $TEST_DIRis blank.How can I recreate locally how CI runs this?
Can I in that case store the current directory
curr_dir=`pwd`and before the secondgit statusexecutecd $curr_dir?mfeurer commentedon Jul 10, 2019
That's tricky. The easiest solution would be to do
export TEST_DIR=/tmp/test/prior to running bash ci_scripts/test.sh.That sounds like a good solution.
mfeurer commentedon Jul 19, 2019
Added in #721.