Skip to content

caching (server dependent) #397

Closed
Closed

Description

@janvanrijn

How about prefixing the caching directories with the inversed URL of the server? Many problems have occurred because we are confusing cache items from the test server with live cache items. This could easily be fixed

In the java connector this is fixed by prefixing the cache directory with the inversed server url, e.g. .openml/cache/org/openml/www/datasets, etc

Activity

  1. added this to the pip-release milestone on Feb 11, 2018
  2. mfeurer commented on Feb 12, 2018

    @mfeurer
    Collaborator

    Great idea!

  3. mfeurer commented on Mar 19, 2018

    @mfeurer
    Collaborator

    After rethinking this a bit, could you please comment on this @janvanrijn ?

    The different toolboxes should store the same information (i.e. xml files). If they don't, that might be a bug.

  4. janvanrijn commented on Mar 19, 2018

    @janvanrijn
    MemberAuthor

    Can you elaborate? I don't see why that is a strict requirement.

    Ideally, yes, but this requires a big effort.
    I wouldn't mind making several changes to the java lib if that unifies matters, would be best to do when we're all together (including representative of mlr)

  5. mfeurer commented on Mar 19, 2018

    @mfeurer
    Collaborator

    It isn't, we just decided to that once upon a time. Still, how can the files differ if only xml files are stored?

  6. janvanrijn commented on Mar 19, 2018

    @janvanrijn
    MemberAuthor

    it's about the directory structure. This one is different in java (I actually prefer the Python directory structure). Also, the pickled files can of course not be red in java and R.

    However, let's discuss that in a different topic. The issue that is raised in this one is that 99% of our (the devs) cache problems come from using cache across servers (test and production). This is something that can be solved fairly easy (in fact, I already did so in the Java lib).

  7. mfeurer commented on Mar 20, 2018

    @mfeurer
    Collaborator

    Sorry for getting side-tracked and talking about something completely different. We should actually check back with the R guys whether they think this is a good idea (I definitely do!) and then also update the docs/Wiki.

    @giuseppec @berndbischl

  8. giuseppec commented on Mar 20, 2018

    @giuseppec
    Member

    Good point, I also ran into that problem several times...

  9. berndbischl commented on Mar 21, 2018

    @berndbischl

    i think if we plan and communicate that change properly, we can easily do that

  10. mfeurer commented on Mar 21, 2018

    @mfeurer
    Collaborator

    As long as we use the solution proposed by @janvanrijn the proposed and current caching structure won't interfere with each other so we would gradually update the different packages?

  11. self-assigned this
    on Apr 3, 2018
  12. mfeurer commented on Apr 4, 2018

    @mfeurer
    Collaborator

    I just added a PR in #432.

  13. self-assigned this
    on Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions