Skip to content

add list_dataset filters #369

Closed
Closed

Description

@joaquinvanschoren

The OpenML list_datasets call allows to filter datasets by number or instances, features, classes, and missing values, but this is not yet supported by the python API.
https://www.openml.org/api_docs/#!/data/get_data_list_filters

Can we please add this?
Also see openml/OpenML#496

Activity

  1. ArlindKadra commented on Mar 15, 2018

    @ArlindKadra
    Member

    @joaquinvanschoren are there any other filters following the ones mentioned above ? @mfeurer should we control the filters names and their values ? In case there are only the filters above, I can use regex to not allow illegal values.

  2. mfeurer commented on Mar 15, 2018

    @mfeurer
    Collaborator

    Could you try whether the server returns a helpful error message in case the filter is illegal? If yes, there is no need to handle this in python code.

  3. janvanrijn commented on Mar 15, 2018

    @janvanrijn
    Member

    The server does, right?

    See, e.g., https://www.openml.org/api/v1/data/list/illegal/123

  4. mfeurer commented on Mar 15, 2018

    @mfeurer
    Collaborator

    Awesome, now @ArlindKadra only needs to figure out whether it prints nicely in python.

  5. ArlindKadra commented on Mar 15, 2018

    @ArlindKadra
    Member

    @janvanrijn @mfeurer The reply from the server is descriptive and nice. In the case of illegal filter values though on the production server you get a no results error and on the test server you get a database error. Do we want this outcome ?
    https://www.openml.org/api/v1/data/list/number_features/ta
    https://test.openml.org/api/v1/data/list/number_features/ta

  6. mfeurer commented on Mar 15, 2018

    @mfeurer
    Collaborator

    I think it should be something like illegal argument error. Could you please post an image @ArlindKadra ?

  7. ArlindKadra commented on Mar 15, 2018

    @ArlindKadra
    Member
  8. added a commit that references this issue on Mar 19, 2018
  9. mfeurer commented on Mar 19, 2018

    @mfeurer
    Collaborator

    Added in #424 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions