Skip to content

Return tables as dataframes #364

Closed

Description

@mfeurer

#363 adds pandas as a dependency and in the tutorials we convert dicts of dicts to dataframes anyway, therefore we could simply return some properties as dataframes. @amueller @janvanrijn what's your opinion on this?

Activity

  1. PGijsbers commented on Mar 18, 2019

    @PGijsbers
    Collaborator

    Should we close this issue as this is possible because of #548, or after the release of 0.9 when dataframes are returned by default?

  2. mfeurer commented on Mar 18, 2019

    @mfeurer
    CollaboratorAuthor

    Nope, this is for function like list_dataset which could naturally be represented as dataframes. Check this example to see which lines could be saved by returning dataframes by default.

    However, I should not decide this by myself. @janvanrijn @joaquinvanschoren @amueller @PGijsbers @ArlindKadra any comments/agreements/disagreements?

  3. joaquinvanschoren commented on Mar 18, 2019

    @joaquinvanschoren
    Contributor

    I would like to have the option to get a dataframe directly. It makes some code a lot shorter and cleaner.

  4. PGijsbers commented on Mar 18, 2019

    @PGijsbers
    Collaborator

    I'm also in favor of (adding the option of) returning a dataframe. I am probably in favor of making it the new default behavior. With pandas becoming the main format of representing (data of the) datasets, it makes sense to also represent the different views with a dataframe.

  5. janvanrijn commented on Mar 19, 2019

    @janvanrijn
    Member

    Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions