Skip to content

api call contains file reading #339

Closed

Description

@amueller

I don't think we need to read files for doing any API calls. I think right now it's only used in the dataset upload, I'm not sure if that's actually good.
Do we want to store arffs on disk for uploading a dataset?

Activity

  1. ArlindKadra commented on May 15, 2018

    @ArlindKadra
    Member

    I have opened issue #442 regarding this topic. Currently the dataset class contains a path to the arff file and when a call is made to upload, the file is read from the path and then uploaded.
    To tackle this, we already opened #440 and an upload_dataset function was added which does not read the files from a path but instead uploads the file directly.
    The implementation in the dataset class is still intact until we figure out how we want to progress with @mfeurer .

  2. ArlindKadra commented on Jun 3, 2018

    @ArlindKadra
    Member

    Solved in #440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions