You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
requirements.txt doesn't contain test dependencies #185
requirements.txt is actually parsed by setup.py, so there is no duplication. Is this a weird setup? You've got more experience on how to install python packages properly, I'm usually happy when it somehow works ;) But I'm not opposed to learn how to do it better.
From my experience, this would require the user to first install the dependencies of the dependencies prior to being able to install the package. Is that correct?
True, but since a requirements.txt is installed via pip, it installs one package after the other. If the order is correct, this works out nicely. I wouldn't know how to do this with a setup.py.
pip entirely ignores requirements.txt, unless you do pip -r requirements.txt after you downloaded the package. If you do pip install openml it will not have any influence.
There is a lot of controversy regarding when to use requirements.txt and install_requires in setup.py. From the python and pip docs they suggest to keep them separate, use concrete dependencies in the requirements.txt and abstract ones in the setup.py. It is suggested not to mix them up together as a good programming practice.
Also from the pip and python documentation, I found this info regarding the requirements file:
"Note that you should not rely on the items in the file being installed by pip in any particular order.".
Activity
mfeurer commentedon Nov 11, 2016
Shouldn't these rather be added as test dependencies to setup.py?
amueller commentedon Nov 11, 2016
yeah probably. I think the current setup is a bit strange. Maybe get rid of requirements.txt and just declare everything in setup.py?
mfeurer commentedon Nov 11, 2016
requirements.txt is actually parsed by setup.py, so there is no duplication. Is this a weird setup? You've got more experience on how to install python packages properly, I'm usually happy when it somehow works ;) But I'm not opposed to learn how to do it better.
amueller commentedon Nov 23, 2016
I think we don't need a requirements.txt and should encode everything in the setup.py.
mfeurer commentedon Nov 24, 2016
From my experience, this would require the user to first install the dependencies of the dependencies prior to being able to install the package. Is that correct?
amueller commentedon Nov 28, 2016
no. the existence of a
requirements.txtdoesn't change anything for dependency resolution.mfeurer commentedon Nov 28, 2016
True, but since a requirements.txt is installed via pip, it installs one package after the other. If the order is correct, this works out nicely. I wouldn't know how to do this with a setup.py.
amueller commentedon Nov 28, 2016
pip entirely ignores requirements.txt, unless you do
pip -r requirements.txtafter you downloaded the package. If you dopip install openmlit will not have any influence.mfeurer commentedon Nov 28, 2016
Sorry for being too unspecific, that's what I actually meant. Does that somehow work with only a setup.py as well?
ArlindKadra commentedon Apr 8, 2018
There is a lot of controversy regarding when to use requirements.txt and install_requires in setup.py. From the python and pip docs they suggest to keep them separate, use concrete dependencies in the requirements.txt and abstract ones in the setup.py. It is suggested not to mix them up together as a good programming practice.
Also from the pip and python documentation, I found this info regarding the requirements file:
"Note that you should not rely on the items in the file being installed by pip in any particular order.".