Skip to content

Provide clear naming for the inconsistent ways to get the cache directory #1124

Closed

Description

@PGijsbers
import openml
openml.config.get_cache_directory()   # is:   '~\\.openml\\org\\openml\\www'
openml.config.cache_directory         # is:   '~\\.openml'

get_cache_directory gets the cache for the currently configured server, while cache_directory gets the root of the cache directory.
set_cache_directory(str) configures the root.

If we plan to maintain an external interface for both types, I propose we:

  • we make them both functions so they are accessed in the same way (and using a function will make a get\set pattern easier where a set can be optionally for the session or saved to the configuration file)
  • make it clear in the name what (part of) the cache directory is returned

Activity

  1. mfeurer commented on Feb 21, 2022

    @mfeurer
    Collaborator

    I agree on both, we should provide getters and setters for stuff from the config, and we should make the naming clearer.

  2. added
    Good First IssueIssues suitable for people new to contributing to openml-python!
    on Jun 11, 2023
  3. added a commit that references this issue on Jun 12, 2023
    8742e19
  4. added a commit that references this issue on Jun 13, 2023
    a7f2639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good First IssueIssues suitable for people new to contributing to openml-python!enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions