Skip to content

Dataset functions are missing from documentation again #1035

Closed

Description

@joaquinvanschoren

Description

When checking the docs for the OpenMLDataset object, only the constructor is documented - none of the operations:
https://openml.github.io/openml-python/develop/generated/openml.OpenMLDataset.html#openml.OpenMLDataset

E.g. dataset.get_data should be fully documented, and there are docstrings - they just don't show up in the docs:
https://github.com/openml/openml-python/blob/develop/openml/datasets/dataset.py#L653

Steps/Code to Reproduce

Check docs: https://openml.github.io/openml-python/develop/generated/openml.OpenMLDataset.html#openml.OpenMLDataset

(same problem for both master and develop)

Expected Results

Documentation on all operations.

Actual Results

Only the constructor is documented.

Activity

  1. PGijsbers commented on Mar 10, 2021

    @PGijsbers
    Collaborator

    Agreed, with the remark that only public methods should be included (i.e. not those that are prefixed with an underscore).

  2. PGijsbers commented on Mar 15, 2021

    @PGijsbers
    Collaborator

    OpenML classes derive some functionality from the OpenMLBase class, e.g. push_tag and remove_tag, publish and so on. These should also be included in the API documentation.

  3. PGijsbers commented on Apr 9, 2021

    @PGijsbers
    Collaborator

    Fixed in #1044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DocumentationGood First IssueIssues suitable for people new to contributing to openml-python!

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions