Skip to content

Remove platforms declaration to avoid deployment target warnings - #661

Closed
CemYil03 wants to merge 3 commits into
openid:masterfrom
CemYil03:patch-1
Closed

Remove platforms declaration to avoid deployment target warnings#661
CemYil03 wants to merge 3 commits into
openid:masterfrom
CemYil03:patch-1

Conversation

@CemYil03

Copy link
Copy Markdown

This is required to fix the following warning in Xcode 13.1:
"The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.0.99."

This is required to fix the following warning in Xcode 13.1:
"The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.0.99."
@Oliver-Binns

Copy link
Copy Markdown

@CemYil03 since the deployment target specified is actually the base required for Swift Package Manager, I'd suggest removing the platforms declaration entirely. This will remove the build warning that appears in lower versions of Xcode too.

I recommend taking a look at these two links if you want further information:
https://forums.swift.org/t/xcode12-minimum-deployment-target-and-spm/40467
https://github.com/nanopb/nanopb/pull/585/files

@simonseyer

Copy link
Copy Markdown

I would second @Oliver-Binns comment. Would be great if you could apply the change by removing the platforms definition altogether.

@CemYil03

CemYil03 commented Dec 2, 2021

Copy link
Copy Markdown
Author

First I thought this could result in compile errors, but it seems to work. The change is now in the latest commit

@CemYil03

CemYil03 commented Dec 22, 2021

Copy link
Copy Markdown
Author

Would really like to merge it in asap. Any idea who to contact?

@Oliver-Binns

Copy link
Copy Markdown

@WilliamDenniss looks like you've merged a few recently? 🙂 please can you take a look here?

@CemYil03

CemYil03 commented Jan 3, 2022

Copy link
Copy Markdown
Author

Someone like @WilliamDenniss or @julienbodet do you have the rights to perform a merge?

@khalideali

Copy link
Copy Markdown

@marcoceppi @iainmcgin @panva Sorry to bother you, but can anyone from openid review and merge this pull request?

@marcoceppi

Copy link
Copy Markdown
Member

I unfortunately can only review the PHP OpenID project. Asking here may help: http://lists.openid.net/mailman/listinfo/openid-code

@julien-baillon

Copy link
Copy Markdown

Please, could anyone merge this MR ? 🙏🏻

@marcoceppi

Copy link
Copy Markdown
Member

@petea Is this something you can help review and merge?

@petea

petea commented Apr 7, 2022

Copy link
Copy Markdown
Collaborator

This has been addressed with #690

@petea petea closed this Apr 7, 2022
@nh7a

nh7a commented Apr 14, 2022

Copy link
Copy Markdown

@petea did you see Oliver-Binns's #661 (comment)? Surely, #690 is better than nothing, but it'll only work until it'll break soon.

@petea

petea commented Apr 14, 2022

Copy link
Copy Markdown
Collaborator

@nh7a I did, and will consider taking that step next.

@petea petea reopened this Apr 14, 2022
@petea petea changed the title iOS 8 out of supported version range in Xcode 13.1 Remove platforms declaration to avoid deployment target warnings Apr 14, 2022
@petea petea added this to the 1.5.1 milestone Aug 5, 2022
@petea petea modified the milestones: 1.6.0, 2.0.0 Sep 9, 2022
@CemYil03 CemYil03 closed this by deleting the head repository Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants