Skip to content

Change iOS deployment target for Xcode 12 - #604

Open
davbeck wants to merge 1 commit into
openid:masterfrom
davbeck:master
Open

Change iOS deployment target for Xcode 12#604
davbeck wants to merge 1 commit into
openid:masterfrom
davbeck:master

Conversation

@davbeck

@davbeck davbeck commented Nov 30, 2020

Copy link
Copy Markdown
Contributor

This removes the warning about iOS 8 no longer being supported in Xcode 12 while maintaining support for older versions of Xcode. Technically checking the compiler version isn’t an exact 1:1 for checking for Xcode version, but in practice should work in all scenarios.

This removes the warning about iOS 8 no longer being supported in Xcode 12 while maintaining support for older versions of Xcode. Technically checking the compiler version isn’t an exact 1:1 for checking for Xcode version, but in practice should work in all scenarios.
@JackoPlane

Copy link
Copy Markdown

@davbeck Could we get this merged? Would a great help to not have Xcode complain about deployment target when using the SPM module

@ghost

ghost commented Feb 18, 2021

Copy link
Copy Markdown

@julienbodet Any chance that this could get released as a patch? The warnings have been there for quite some time now 😬

@JackoPlane

Copy link
Copy Markdown

@WilliamDenniss Could we get this merged some time soon?

@ChrisPearce

Copy link
Copy Markdown

Is there any update of whether this PR will be merged?

Our CI build processes continue to show these warnings when using this library

@robinhayward

robinhayward commented Apr 14, 2021

Copy link
Copy Markdown

+1 for a merge please, can't find any other way to remove these warnings. (SPM)

@moban-michael

Copy link
Copy Markdown

Like to see it merged asap to get rid of warnings with SPM

@jakobmygind

Copy link
Copy Markdown

Please merge this

@CemYil03

CemYil03 commented Jan 3, 2022

Copy link
Copy Markdown

Is also covered in #661. Can anyone contact the maintainers to merge one of those? These warnings are really annoying to me...

@Oliver-Binns

Copy link
Copy Markdown

#661 is a better implementation of this. It would be preferable to merge that instead.

The platform declarations can be removed entirely as they match the minimum version supported by SPM:
https://forums.swift.org/t/xcode12-minimum-deployment-target-and-spm/40467
https://github.com/nanopb/nanopb/pull/585/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants