Skip to content

Pre-4.7.0 check.#763

Merged
asmorkalov merged 7 commits into
opencv:4.xfrom
asmorkalov:as/pre-4.7.0
Dec 29, 2022
Merged

Pre-4.7.0 check.#763
asmorkalov merged 7 commits into
opencv:4.xfrom
asmorkalov:as/pre-4.7.0

Conversation

@asmorkalov

Copy link
Copy Markdown
Collaborator

No description provided.

@asmorkalov asmorkalov force-pushed the as/pre-4.7.0 branch 6 times, most recently from cac5c2b to 3d5098f Compare December 25, 2022 15:04
@asmorkalov

Copy link
Copy Markdown
Collaborator Author

@alalek there is linker issue on Windows:

     Creating library D:/a/opencv-python/opencv-python/_skbuild/win-amd64-3.7/cmake-build/lib/Release/opencv_python3.lib and object D:/a/opencv-python/opencv-python/_skbuild/win-amd64-3.7/cmake-build/lib/Release/opencv_python3.exp
cv2.obj : error LNK2019: unresolved external symbol "public: virtual class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl cv::xfeatures2d::SURF::getDefaultName(void)const " (?getDefaultName@SURF@xfeatures2d@cv@@UEBA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ) referenced in function "[thunk]:public: virtual class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl cv::xfeatures2d::SURF::getDefaultName`vtordisp{4294967292,0}' (void)const " (?getDefaultName@SURF@xfeatures2d@cv@@$4PPPPPPPM@A@EBA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ) [D:\a\opencv-python\opencv-python\_skbuild\win-amd64-3.7\cmake-build\modules\python3\opencv_python3.vcxproj]
D:\a\opencv-python\opencv-python\_skbuild\win-amd64-3.7\cmake-build\lib\python3\Release\cv2.pyd : fatal error LNK1120: 1 unresolved externals [D:\a\opencv-python\opencv-python\_skbuild\win-amd64-3.7\cmake-build\modules\python3\opencv_python3.vcxproj]

Looking on it right now.

@asmorkalov

Copy link
Copy Markdown
Collaborator Author

Fix on WIndows: opencv/opencv_contrib#3403

@asmorkalov asmorkalov force-pushed the as/pre-4.7.0 branch 5 times, most recently from 5f13a4f to 6df76ba Compare December 26, 2022 15:06
@asmorkalov asmorkalov force-pushed the as/pre-4.7.0 branch 2 times, most recently from 2666551 to 4bc200f Compare December 28, 2022 14:05
Comment thread scripts/install.sh Outdated
Comment thread patch_auditwheel_whitelist.py Outdated
@asenyaev

asenyaev commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

At the moment also the old multibuild commit (2021 year). Let's use the current one in 4.x branch - bce1637e202cb52b0e7ea42baa1cccc894b82806

The PR where it was added - #684

The change in a submodule with a test docker image was committed in March this year (change).

Comment thread patch_auditwheel_whitelist.py Outdated
@asmorkalov asmorkalov merged commit 339bca5 into opencv:4.x Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants