fix(sonar): resolve 105 SonarQube issues (BLOCKER, CRITICAL, MAJOR, MINOR)#353
Open
scheilch wants to merge 2 commits into
Open
fix(sonar): resolve 105 SonarQube issues (BLOCKER, CRITICAL, MAJOR, MINOR)#353scheilch wants to merge 2 commits into
scheilch wants to merge 2 commits into
Conversation
…INOR) - fix: add assertions to 39 tests without assertions (S2699) - refactor: extract 4 duplicate string literals to constants (S1192) - fix: add explicit default values to 3 Pydantic optional fields (S8396) - fix: replace void operator with direct function call (S3735) - fix: use logger.exception() instead of logger.error() in 17 except blocks (S8572) - security: sanitize user-controlled data in 41 logging calls (S5145) All tests passing: - Backend: 2166 passed, 1 skipped - Frontend: 953 passed, 1 skipped
Contributor
❌ CI Failed
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 105 SonarQube code quality issues across backend, frontend, and CI workflows. All issues have been fixed systematically with full test coverage verification.
Changes
Backend Fixes (Python)
logger.error()tologger.exception()for proper stack traces (S8572)Frontend Fixes (TypeScript)
CI/CD Workflow Fixes
Test Results
Backend: ✅ 2166 passed, 1 skipped
Frontend: ✅ 953 passed, 1 skipped
Progress
105/105 issues resolved ✅
Related
Part of continuous code quality improvement. No functional changes — only code hygiene and maintainability improvements.