Conversation
Add a default HTTPListenerPolicy targeting the default-gateway in the data-plane Helm chart. Enable it by default, gated on gatewayClassName being "kgateway". This allows workloads with Websocket endpoints to function correctly out of the box without requiring manual cluster-wide operations. Also, remove the manual HTTPListenerPolicy creation steps from the doclet and echo-websocket-service sample READMEs. Refs openchoreo#4068, openchoreo#3915 Signed-off-by: kavix <[email protected]>
kavix
requested review from
ChathurangaKCD,
JanakaSandaruwan,
LakshanSS,
Mirage20,
NomadXD,
VajiraPrabuddhaka,
akila-i,
chalindukodikara,
chathuranga95,
isala404,
mevan-karu,
nilushancosta,
sameerajayasoma and
yashodgayashan
as code owners
July 3, 2026 10:09
📝 WalkthroughWalkthroughAdds a Helm template that conditionally creates a default ChangesDefault HTTPListenerPolicy support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Websocketis a first-class workload endpoint type in OpenChoreo, but connections failed out of the box because KGateway (based on Envoy) disables WebSocket upgrades by default. Enabling upgrades requires anHTTPListenerPolicy(gateway.kgateway.dev/v1alpha1) on the Gateway listener.This PR deploys a default
HTTPListenerPolicyin the data-plane Helm chart so that WebSocket upgrades work out-of-the-box for all users without manual cluster-wide operations.Approach
install/helm/openchoreo-data-plane/templates/gateway/httplistenerpolicy.yamlwhich creates anHTTPListenerPolicytargeting the default gateway (gateway-default) with WebSocket upgrades enabled.gateway.enabledandgateway.gatewayClassName == "kgateway"to align with the KGateway-specific CRD availability and prevent installation failures on non-KGateway configurations.gateway.httpListenerPolicyconfiguration undergatewayinvalues.yamlandvalues.schema.jsonto allow users to toggle the policy.HTTPListenerPolicyfromsamples/from-image/doclet/README.mdandsamples/from-image/echo-websocket-service/README.md.Related Issues
Closes #4069
Refs #3915
Checklist
backport/<release-branch>label if this should be backported (e.g.,backport/release-v1.0)