Change request to allow more characters in select#2
Merged
Conversation
To reflect the actual implementation regarding Sort.
Collaborator
Author
|
Hi @langecode and @AllanHoejgaardJensen Have you had a chance to review this PR? Best regards |
langecode
approved these changes
Aug 5, 2019
Member
langecode
left a comment
langecode
left a comment
There was a problem hiding this comment.
I think it looks good. Thanks for the contribution and the included clean ups. I will just let @AllanHoejgaardJensen have a few more day to take a look then I will merge.
Collaborator
Author
Hi |
Member
|
@gringostar I will make a release latest in the weekend. Thanks for othe contribution. |
Member
|
Published as v1.0.3 - sorry for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
<attribute>+/-)