Create an example directory and add some code examples.#944
Merged
Conversation
baylesj
requested changes
Jun 24, 2019
dota17
force-pushed
the
code_example
branch
2 times, most recently
from
June 26, 2019 11:13
75313b8 to
9de4234
Compare
…for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Wed Jul 10 21:26:16 2019 +0800 # # On branch code_example # Your branch is up-to-date with 'origin/code_example'. # # Changes to be committed: # modified: example/CMakeLists.txt #
BillyDonahue
requested changes
Jul 14, 2019
Member
Author
|
@baylesj @BillyDonahue Thank you all for all your precious suggests, and now the problem is that the build failed for |
Member
Author
|
@baylesj @BillyDonahue I have modified all change requests, and if there is any thing else to be done, please point it out. |
baylesj
requested changes
Sep 16, 2019
Contributor
|
I am glad you did this patch, I definitely want example code for this project. If you can fix up the errors I'm happy to merge it in. |
dota17
force-pushed
the
code_example
branch
from
September 17, 2019 09:24
9229a9c to
ca763ab
Compare
dawesc
pushed a commit
to EFTlab/jsoncpp
that referenced
this pull request
Sep 25, 2019
…parsers#944) * update example directory * modify some compile error. * update with clang-format * update * update * add_definitions("../include/json") # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Wed Jul 10 21:26:16 2019 +0800 # # On branch code_example # Your branch is up-to-date with 'origin/code_example'. # # Changes to be committed: # modified: example/CMakeLists.txt # * change CMakeLists.txt * update streamWrite.cpp * update * Update readFromStream.cpp * fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personally speaking, I think the original code examples for this project are not very easy to find, and the readability is not very high,so I create a example directory and add some code examples here.